Conversation
bpblanken
commented
Sep 27, 2023
bpblanken
commented
|
Sorry, I should have checked that this ticket was clearer before assigning it over to you. When the ticket says we should show it "similar to how we show it for the Pathogenicity override", it means we should show it directly in the panel above all the filters, not on a hover. The text we should use should be something like "Filter by reported annotation. Variants will be returned if they have ANY of the specified annotations, including if they have a Splice AI score above the threshold and no other annotations. This filter is overridden by the pathogenicity filter, so variants will be returned if they have the specified pathogenicity even if none of the annotation filters match" 
|
|
👍 Do we also want to mention "screen"? It has the same behavior as splice_ai I believe? |
|
I feel like screen is covered by "ANY of the specified annotations", it pretty much looks to users like thr other annotations in the filter so while in the database the filtering is quite different, to the user I do not think it is |
bpblanken
force-pushed
the
benb/3579
branch
from
4fda717 to
7feda92
Compare
|
Updated screenshot: |
| const labelHelp = ( | ||
| <div> | ||
| {`Enter a numeric cutoff for ${label}`} | ||
| {dangerThreshold && ( |
There was a problem hiding this comment.
I believe this is dead code after the recent changes... is that correct?
There was a problem hiding this comment.
yeah, but actually we should be replacing this with updated logic from the config thresholds, not just removing it. I would leave it for now and make a ticket to properly update it (or you can give that a go if you want)
2 participants
